Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pass wagmi params to createConfig method #3324

Closed
wants to merge 3 commits into from
Closed

refactor: pass wagmi params to createConfig method #3324

wants to merge 3 commits into from

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Nov 25, 2024 •
edited
Loading

Description

Passes given WagmiAdapter constructor parameters to createConfig method. Adds related unit tests. @svenvoskamp's changes in #3310

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: df418e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-adapter-wagmi Patch
@apps/demo Patch
@apps/gallery Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new 🛑 Canceled (Inspect) Nov 25, 2024 7:50am
appkit-laboratory 🛑 Canceled (Inspect) 💬 Add feedback Nov 25, 2024 7:50am
appkit-vue-solana 🛑 Canceled (Inspect) Nov 25, 2024 7:50am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:50am
vue-wagmi-example 🛑 Canceled (Inspect) Nov 25, 2024 7:50am

@enesozturk enesozturk mentioned this pull request Nov 25, 2024
Merged
10 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 336.33% 4865 / 23641
🔵 Statements 336.33% 4865 / 23641
🔵 Functions 368.88% 388 / 1431
🔵 Branches 475.4999999999999% 745 / 1725
File CoverageNo changed files found.
Generated in workflow #7580 for commit df418e9 by the Vitest Coverage Report Action

@enesozturk enesozturk changed the title refactor/pass wagmi params to createConfig method refactor: pass wagmi params to createConfig method Nov 25, 2024
@enesozturk
Copy link
Contributor Author

Handled in #3310

@enesozturk enesozturk closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvoskamp svenvoskamp svenvoskamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enesozturk @svenvoskamp